This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
remove webSecurity:false in webPreferences #10242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diracdeltas
commented
Aug 1, 2017
js/stores/appStore.js
Outdated
| sharedWorker: true, | ||
| nodeIntegration: false, |
There was a problem hiding this comment.
this is not needed anymore, right?
bridiver
reviewed
Aug 1, 2017
app/browser/tabs.js
Outdated
| @@ -706,6 +706,7 @@ const api = { | |||
| }, | |||
|
|
|||
| executeScriptInBackground: (script, cb) => { | |||
| // Do not edit without security review | |||
There was a problem hiding this comment.
this is not a web-accessible api and is only used in the browser process. Actually now that we have worker threads it isn't used at all
bridiver
reviewed
Aug 1, 2017
js/stores/appStore.js
Outdated
| partition: 'default', | ||
| webSecurity: false, | ||
| allowFileAccessFromFileUrls: true, |
There was a problem hiding this comment.
I don't know if these are necessary anymore either since we're using chrome://brave urls now
|
@bridiver ready for review |
NejcZdovc
modified the milestones:
0.20.x (Developer Channel),
0.21.x (Nightly Channel)
bridiver
reviewed
Aug 28, 2017
app/browser/tabs.js
Outdated
| @@ -699,22 +698,6 @@ const api = { | |||
| }) | |||
| }, | |||
|
|
|||
| executeScriptInBackground: (script, cb) => { | |||
There was a problem hiding this comment.
I think this is being used in a PR in progress
There was a problem hiding this comment.
Yes this is used in this PR #10325
and add some comments for security-sensitive code fix #10240
diracdeltas
force-pushed
the
fix/10240
branch
from
4992f99
to
019f85b
Compare
|
fixed the merge conflict. @NejcZdovc @bridiver could one of you review plz |
|
no-qa-needed? |
diracdeltas
added a commit
that referenced
this pull request
Sep 13, 2017
remove webSecurity:false in webPreferences
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add some comments for security-sensitive code
fix #10240
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests